Conversation
mdellweg
force-pushed
the
lint-format-ruff
branch
3 times, most recently
from
dc2c514 to
b39b068
Compare
Also activates ruff lint rulesets for preventing pulpcore.app imports, invalid gettext expressions and stray debugger statements.
mdellweg
force-pushed
the
lint-format-ruff
branch
from
b39b068 to
9b5546b
Compare
mdellweg
commented
Apr 23, 2026
|
|
||
| - name: "Check for common gettext problems" | ||
| run: | | ||
| sh .ci/scripts/check_gettext.sh |
Member
Author
There was a problem hiding this comment.
There was a set of flake8 rules for this all along... We activate them in ruff with the "INT" ruleset.
dralley
reviewed
Apr 23, 2026
| import tomllib | ||
| from pathlib import Path | ||
|
|
||
| import tomllib |
Contributor
There was a problem hiding this comment.
This is in the stdlib so it's a bit weird that it gets sorted into the 3rd party section
Member
Author
There was a problem hiding this comment.
I think this tool is sensitive on the python version and tomllib was only recently added to std...
Contributor
There was a problem hiding this comment.
It was added in 3.11 so not that recent :)
dralley
approved these changes
Apr 23, 2026
Contributor
dralley
left a comment
dralley
left a comment
There was a problem hiding this comment.
No objections other than the weirdness with tomllib. But not blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also activates ruff lint rulesets for preventing pulpcore.app imports and stray debugger statements.